Setup initial integration tests

[pradtke]

• Restore old www path names in routes to ease upgrades
• Make wctx optional since it was not required in the released version.

[codecov[bot]]

Codecov Report

Merging #8 (5475591) into master (d11fafd) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff            @@
##             master      #8   +/-   ##
========================================
  Coverage      0.00%   0.00%           
  Complexity       78      78           
========================================
  Files             5       5           
  Lines           356     357    +1     
========================================
- Misses          356     357    +1     

[tvdijen]

Great work Patrick! My only suggestion would be to use the PEMCertificatesMock instead of adding the sample certs to this repo. Here's an example; https://github.com/simplesamlphp/saml2/blob/90ddb45233c6abd79c3a912d55f715519f7c9352/tests/SAML2/SignedElementTestTrait.php#L54

[pradtke]

Thanks for pointing out PEMCertificatesMock @tvdijen! That's a good change. I've updated the PR.

[tvdijen]

One more question I'm asking myself, without (I admit) checking too much of the code, is whether we still need the BuiltinServer when we have routing? The PRP-test you're adding seems a lot like a controller-test, but this one is not covering the AdfsController-class? Or should we add a @covers tag to see the added coverage?

[pradtke]

One more question I'm asking myself, without (I admit) checking too much of the code, is whether we still need the BuiltinServer when we have routing?

I was hoping I wouldn't. But as ADFS::receiveAuthnRequest does it's thing eventually IdP::postAuthProc is called which expects the Responder function to have called exit(). So as part of this PR ADFS::postResponse now calls exit. Without that exit the Assert::true(false); in postAuthProc would fail.

[tvdijen]

Superseded by #10