search

simplesamlphp / simplesamlphp-module-casserver

CAS 1.0 and 2.0 compliant CAS server module for simpleSAMLphp
GNU Lesser General Public License v2.1
6 stars 10 forks source link

Messages 'sspmod_casserver_Cas_Ticket_MemCacheTicketStore' is now using namespaces #39

Open slanthier1 opened 1 year ago

slanthier1 commented 1 year ago

Hello!

We are seeing messages like those in the log/simplesamlphp.log file when I access https://my.host.org/cas/login : 

The class or interface 'sspmod_casserver_Cas_Ticket_MemCacheTicketStore' is now using namespaces, please use 'SimpleSAML\Module\casserver\Cas\Ticket\MemCacheTicketStore' instead.

 The class or interface 'sspmod_casserver_Cas_Ticket_TicketFactory' is now using namespaces, please use 'SimpleSAML\Module\casserver\Cas\Ticket\TicketFactory' instead.

I would need some help or advice to get rid of them.

I first hoped that I could simply edit the config/module_casserver.php file, but I finally cannot figure how to change it.

All the best,

tvdijen commented 1 year ago

You must be using a very old version.. Try upgrading

tvdijen commented 1 year ago

Hi @slanthier1 ! You need any help, or is there any way we can assist you? My best guess from what you are telling is that you are using SSP 1.19.x with the casserver-module 6.0.0 which is still using PSR-1 style namespaces.

There is a newer version of the casserver-module available (6.2.0) which should suppress the messages you are seeing. I do wonder if anyone ever tested this newer version, because virtually no one is using this module (at least not on my side of the pond). If you are willing to try it, I can support you and fix any potential bugs you may run into.

@shamus13 and @pradtke: Are any of you still somehow involved / using this module?

slanthier1 commented 1 year ago

Hello @tvdijen !

Thanks for the following.

You were right : I am using SSP-1.19.6 and, last week, I was still downloading the version 6.0.0 of the simplesamlphp-module-cassserver.

This use of v6.0.0 was caused by the line I was using in my Dockerfile : php composer.phar require simplesamlphp/simplesamlphp-module-casserver (note the absence of tag). I feel that I was then querying the "latest" tag, which corresponds to v6.0.0.

Since I read your first advice (thank you for pointing to the use of a very old version), i modified the line to explicitly query v6.2.0 : php composer.phar require simplesamlphp/simplesamlphp-module-casserver:v6.2.0

Unfortunately, I still obtain the exactly same errors in the simplesamlphp.log file :

Oct 11 12:17:13 xxx 4 [596c2d40f3] The class or interface 'sspmod_casserver_Cas_Ticket_MemCacheTicketStore' is now using namespaces, please use 'SimpleSAML\Module\casserver\Cas\Ticket\MemCacheTicketStore' instead.
Oct 11 12:17:13 xxx 4 [596c2d40f3] The class or interface 'sspmod_casserver_Cas_Ticket_TicketFactory' is now using namespaces, please use 'SimpleSAML\Module\casserver\Cas\Ticket\TicketFactory' instead.

So, I guessed that I may was using a very old version of simplesamlphp-module-memcacheMonitor.

The same way it was for simplesamlphp-module-casserver, I wasn't explicitely asking for a special tag of simplesamlphp-module-memcacheMonitor. So, I feel that the latest release of simplesamlphp-module-memcacheMonitor was allowing me to obtain version 0.9.1.

I tried successively version 1.1.0, version 1.0.2, but this was causing error in my build process. The best version of simplesamlphp-module-memcacheMonitor with which I was able to built is v0.9.3. (But I still get the errors in the log file).

Well, as you seem confident that the problem is lying in module-casserver, maybe I was wrong with my steps with module-memcacheMonitor.

The fact is : I still have the same problem.

So, yes, with great pleasure : if you are able to help me with this, I would be delighted. Stéphanie

tvdijen commented 1 year ago

Well, since support for v1.19 is nearly coming to and end, perhaps it's better if I help you with upgrading SSP in general. Were you already planning an upgrade?

slanthier1 commented 1 year ago

Hi @tvdijen!

Yes, we are in the process to go for an update toward SSP2.

Maybe could we then put an hold on the actual issue. I could come back after our upgrade to SSP2 to inform on the result of the general upgrade on this particular issue.

It's kind from your part to offer help. We will first work a little more before requesting assistance on the general upgrade.

All the best, Stéphanie

tvdijen commented 1 year ago

Very well! Just be aware that virtually no one is using this module and it may not work well with SSP 2.0, but that's where I can assist. There is a v7.0.0-rc1 that should work, but I don't think anyone ever tried it with SSP 2.0. Perhaps @pradtke knows this, but otherwise we will make it work with your feedback :muscle:

slanthier1 commented 1 year ago

Thank you very much for your advices. May I ask this : as you are telling me that almost noone is using the module, could there be another path to offer CAS authentication via SSP which I could not be aware of?

tvdijen commented 1 year ago

Not that I'm aware of, no... I'm not saying you shouldn't use the module, it just needs some TLC. We rely on our community to keep all the modules working and for this particular module the audience seems kinda small. It hasn't had the attention needed to remain in working condition with newer versions of SSP. Like I said, we'll make it work! I can fix anything for you with the right feedback