simplesamlphp / simplesamlphp-module-ldap

Module that provides authentication against LDAP stores

GNU Lesser General Public License v2.1

4 stars 8 forks source link

Simplify getting authsource data from config #8

Closed jornane closed 5 years ago

jornane commented 5 years ago

The code uses getConfigItem, which wraps a Configuration around the array, after which it extracts the array. I checked the code, there does not seem any processing or sanity checking in the Configuration class, so the wrapping step is entirely unnecessary. So let's get rid of it.

codecov-io commented 5 years ago

Codecov Report

Merging #8 into master will increase coverage by <.01%. The diff coverage is 0%.

@@             Coverage Diff             @@
##             master      #8      +/-   ##
===========================================
+ Coverage      1.33%   1.34%   +<.01%     
  Complexity      242     242              
===========================================
  Files             8       8              
  Lines           821     820       -1     
===========================================
  Hits             11      11              
+ Misses          810     809       -1