search

simplesamlphp / simplesamlphp-module-negotiate

Negotiate module
GNU Lesser General Public License v2.1
4 stars 5 forks source link

WIP: Add controller for the negotiate-module #1

Closed tvdijen closed 4 years ago

tvdijen commented 5 years ago

The retry + backend methods in the controller need work to be able to return some kind of Response

knixeur commented 4 years ago

You could just create a new Response() and send that, Template inherits from Response, and response default data when calling send() is status code 200, empty content, empty headers. I'm not sure however, what assert(false);'s response was in the main version.

codecov[bot] commented 4 years ago

Codecov Report

Merging #1 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##             master    #1   +/-   ##
======================================
  Coverage         0%    0%           
- Complexity       42    49    +7     
======================================
  Files             1     2    +1     
  Lines           167   218   +51     
======================================
- Misses          167   218   +51
Impacted Files Coverage Δ Complexity Δ
lib/Controller/Negotiate.php 0% <0%> (ø) 7 <7> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d404ec6...321df82. Read the comment docs.