simplesamlphp / simplesamlphp-module-negotiate

Negotiate module
GNU Lesser General Public License v2.1
4 stars 5 forks source link

Migrate to LDAP-module v2 #5

Closed tvdijen closed 1 year ago

tvdijen commented 1 year ago

Depends on https://github.com/simplesamlphp/simplesamlphp-module-ldap/pull/37 to be merged and released into v2.1

Updates the module to use the new major version of the LDAP-module. Drops the requirement to set all the ldap-connection details in the negotiate-authsource. Instead the backend-authsource is used. The fallback-authsource can now also be a non-ldap source (backend and fallback are now differentiated).

codecov[bot] commented 1 year ago

Codecov Report

Merging #5 (ef8e97e) into master (a92cac1) will increase coverage by 3.44%. The diff coverage is 0.00%.

:exclamation: Current head ef8e97e differs from pull request most recent head 26fa964. Consider uploading reports for the commit 26fa964 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5 +/- ## ============================================ + Coverage 26.66% 30.10% +3.44% + Complexity 57 54 -3 ============================================ Files 2 2 Lines 210 186 -24 ============================================ Hits 56 56 + Misses 154 130 -24 ```
tvdijen commented 1 year ago

Tested & works like a charm in different scenarios:

Once approved, I will make the exact same changes to the negotiate-ext module