simplesamlphp / simplesamlphp-module-oidc

A SimpleSAMLphp module for OIDC OP support.
Other
45 stars 22 forks source link

For user claims, substitute invalid utf8 chars with replacement char #194

Closed cicnavi closed 1 year ago

cicnavi commented 1 year ago

Fixes #193

codecov[bot] commented 1 year ago

Codecov Report

Base: 39.60% // Head: 39.33% // Decreases project coverage by -0.27% :warning:

Coverage data is based on head (621f6a5) compared to base (40e2ea3). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #194 +/- ## ============================================ - Coverage 39.60% 39.33% -0.27% - Complexity 868 871 +3 ============================================ Files 107 107 Lines 2987 3460 +473 ============================================ + Hits 1183 1361 +178 - Misses 1804 2099 +295 ``` | [Impacted Files](https://codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp) | Coverage Δ | | |---|---|---| | [lib/Entity/UserEntity.php](https://codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp#diff-bGliL0VudGl0eS9Vc2VyRW50aXR5LnBocA==) | `100.00% <100.00%> (ø)` | | | [lib/Utils/FingerprintGenerator.php](https://codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp#diff-bGliL1V0aWxzL0ZpbmdlcnByaW50R2VuZXJhdG9yLnBocA==) | `66.66% <0.00%> (-13.34%)` | :arrow_down: | | [lib/Services/DatabaseMigration.php](https://codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp#diff-bGliL1NlcnZpY2VzL0RhdGFiYXNlTWlncmF0aW9uLnBocA==) | `15.92% <0.00%> (-7.02%)` | :arrow_down: | | [lib/Controller/LogoutController.php](https://codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp#diff-bGliL0NvbnRyb2xsZXIvTG9nb3V0Q29udHJvbGxlci5waHA=) | `61.42% <0.00%> (-2.64%)` | :arrow_down: | | [lib/Services/ConfigurationService.php](https://codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp#diff-bGliL1NlcnZpY2VzL0NvbmZpZ3VyYXRpb25TZXJ2aWNlLnBocA==) | `44.15% <0.00%> (-2.33%)` | :arrow_down: | | [lib/Entity/ClientEntity.php](https://codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp#diff-bGliL0VudGl0eS9DbGllbnRFbnRpdHkucGhw) | `74.11% <0.00%> (-1.20%)` | :arrow_down: | | [lib/Server/Grants/AuthCodeGrant.php](https://codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp#diff-bGliL1NlcnZlci9HcmFudHMvQXV0aENvZGVHcmFudC5waHA=) | `5.15% <0.00%> (-0.70%)` | :arrow_down: | | [lib/Form/ClientForm.php](https://codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp#diff-bGliL0Zvcm0vQ2xpZW50Rm9ybS5waHA=) | `0.00% <0.00%> (ø)` | | | [lib/Services/Container.php](https://codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp#diff-bGliL1NlcnZpY2VzL0NvbnRhaW5lci5waHA=) | `0.00% <0.00%> (ø)` | | | ... and [57 more](https://codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/194?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

pradtke commented 1 year ago

Thanks @cicnavi