simplesamlphp / simplesamlphp-module-oidc

A SimpleSAMLphp module for OIDC OP support.
Other
45 stars 22 forks source link

Caching conformance suit can cause weird problems. Stop caching #195

Closed pradtke closed 1 year ago

pradtke commented 1 year ago

Caching the conformance suit only saves 1 minute (since we build it without tests) while sometimes the caching causes problems (perhaps related to the cache key not taking into account suite version)

codecov[bot] commented 1 year ago

Codecov Report

Base: 40.05% // Head: 40.05% // No change to project coverage :thumbsup:

Coverage data is based on head (f80ac4f) compared to base (b28047e). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## ssp2-test #195 +/- ## ============================================ Coverage 40.05% 40.05% Complexity 871 871 ============================================ Files 107 107 Lines 3645 3645 ============================================ Hits 1460 1460 Misses 2185 2185 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

pradtke commented 1 year ago

test pass. closing and just pushing fix into sspv2