simplesamlphp / simplesamlphp-module-oidc

A SimpleSAMLphp module for OIDC OP support.
Other
45 stars 22 forks source link

Resolve PHP v8 depreciations in v2 #199

Closed cicnavi closed 1 year ago

cicnavi commented 1 year ago

closes #181 closes #192

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 14.28% and project coverage change: +0.71% :tada:

Comparison is base (a3f7643) 39.28% compared to head (6913621) 40.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## version-2 #199 +/- ## =============================================== + Coverage 39.28% 40.00% +0.71% - Complexity 874 879 +5 =============================================== Files 107 107 Lines 3464 3662 +198 =============================================== + Hits 1361 1465 +104 - Misses 2103 2197 +94 ``` | [Files Changed](https://app.codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp) | Coverage Δ | | |---|---|---| | [lib/Form/ClientForm.php](https://app.codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp#diff-bGliL0Zvcm0vQ2xpZW50Rm9ybS5waHA=) | `0.00% <0.00%> (ø)` | | | [lib/Form/Controls/CsrfProtection.php](https://app.codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp#diff-bGliL0Zvcm0vQ29udHJvbHMvQ3NyZlByb3RlY3Rpb24ucGhw) | `0.00% <0.00%> (ø)` | | | [lib/Server/Grants/AuthCodeGrant.php](https://app.codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp#diff-bGliL1NlcnZlci9HcmFudHMvQXV0aENvZGVHcmFudC5waHA=) | `4.88% <0.00%> (-0.20%)` | :arrow_down: | | [lib/Server/Grants/ImplicitGrant.php](https://app.codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp#diff-bGliL1NlcnZlci9HcmFudHMvSW1wbGljaXRHcmFudC5waHA=) | `0.00% <0.00%> (ø)` | | | [lib/Server/Grants/Traits/IssueAccessTokenTrait.php](https://app.codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp#diff-bGliL1NlcnZlci9HcmFudHMvVHJhaXRzL0lzc3VlQWNjZXNzVG9rZW5UcmFpdC5waHA=) | `0.00% <ø> (ø)` | | | [lib/Server/Validators/BearerTokenValidator.php](https://app.codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp#diff-bGliL1NlcnZlci9WYWxpZGF0b3JzL0JlYXJlclRva2VuVmFsaWRhdG9yLnBocA==) | `100.00% <ø> (ø)` | | | [lib/Services/IdTokenBuilder.php](https://app.codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp#diff-bGliL1NlcnZpY2VzL0lkVG9rZW5CdWlsZGVyLnBocA==) | `0.00% <0.00%> (ø)` | | | [lib/Utils/Checker/Rules/IdTokenHintRule.php](https://app.codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp#diff-bGliL1V0aWxzL0NoZWNrZXIvUnVsZXMvSWRUb2tlbkhpbnRSdWxlLnBocA==) | `100.00% <ø> (ø)` | | | [lib/Utils/Checker/Rules/ScopeRule.php](https://app.codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp#diff-bGliL1V0aWxzL0NoZWNrZXIvUnVsZXMvU2NvcGVSdWxlLnBocA==) | `95.83% <50.00%> (-4.17%)` | :arrow_down: | | [lib/Utils/UniqueIdentifierGenerator.php](https://app.codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp#diff-bGliL1V0aWxzL1VuaXF1ZUlkZW50aWZpZXJHZW5lcmF0b3IucGhw) | `50.00% <50.00%> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/199?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp) | | ... and [45 files with indirect coverage changes](https://app.codecov.io/gh/simplesamlphp/simplesamlphp-module-oidc/pull/199/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.