search

simplesamlphp / simplesamlphp-module-oidc

A SimpleSAMLphp module for OIDC OP support.
Other
45 stars 22 forks source link

Update jQuery #200

Closed cicnavi closed 1 year ago

cicnavi commented 1 year ago

Because of https://github.com/simplesamlphp/simplesamlphp-module-oidc/security/dependabot/1

Tried creating, editing and deleting client from the UI, everything seems fine.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (2867977) 43.54% compared to head (1fe5882) 43.54%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #200 +/- ## ========================================= Coverage 43.54% 43.54% Complexity 877 877 ========================================= Files 107 107 Lines 3658 3658 ========================================= Hits 1593 1593 Misses 2065 2065 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simplesamlphp)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

tvdijen commented 1 year ago

Do we really need jQuery in the first place? I also notice we have a copy of clipboard.js in this module as well.. We can use the one available in SSP instead.

cicnavi commented 1 year ago

It is used in client management UI.

cicnavi commented 1 year ago

From my perspective, I would rather leave module related assets in the module itself. Since I'm not that involved into core SimpleSAMLphp development, there is a chance I'll miss to see if you ever remove / update / rename... any asset in SSP. If you would like to take care of cases like that, feel free to change it...