Closed cicnavi closed 9 months ago
Attention: 341 lines
in your changes are missing coverage. Please review.
Comparison is base (
895abfd
) 52.65% compared to head (b973d1c
) 53.26%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The following will be postponed for version 6:
Below are some internal changes that should not have impact for the OIDC OP implementors. However, if you are using this module as a library or extending from it, you will probably encounter breaking changes, since a lot of code has been refactored:
It's a bit much to review, but I think it's mostly about the strict_types=1
, right?
Erm, actually there was fair amount of refactoring done. I've described changes in https://github.com/simplesamlphp/simplesamlphp-module-oidc/blob/dev-v5/UPGRADE.md
The most important for me is that you are ok with creating the major release of the module compatible with SSP v2.1 now (without the above mentioned features that I've originally planed in v5).
Yeah sure, go ahead!
Since SimpleSAMLphp v2.1 is out for some time, start with v5 of the module which is compatible with SSP v2.1, so users can start using it.