search

simplesamlphp / simplesamlphp-module-oidc

A SimpleSAMLphp module for OIDC OP support.
Other
45 stars 22 forks source link

Update CsrfProtection.php #213

Closed rmdashrfslash closed 9 months ago

rmdashrfslash commented 9 months ago

Rename of directory from Form --> Forms, had to update code too.

tvdijen commented 9 months ago

I think we should keep the names in singular form, so Form instead of Forms. Other than that, thanks for fixing this and pointing this out @rmdashrfslash !

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9b3cd12) 53.26% compared to head (0b850c4) 53.26%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #213 +/- ## ========================================= Coverage 53.26% 53.26% Complexity 984 984 ========================================= Files 109 109 Lines 3809 3809 ========================================= Hits 2029 2029 Misses 1780 1780 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cicnavi commented 9 months ago

Thanks @rmdashrfslash! I've changed it to array callable format so it can be catched by static analysers in the future.

Plural is in line with the rest of the codebase.