Closed ioigoume closed 3 months ago
@ioigoume thanks for the contribution! @pradtke will you be reviewing this? A few hints:
- composer pre-commit
Hi @cicnavi thank you for the comments. I will address the changes and push the fixes.
Thank you @cicnavi and @ioigoume . I'll run a few tests tomorrow and then I can merge it in.
I hurried up with merging stuff to wip-version-6 bc Tim announced more static analysis related commits coming next week 😅... There were some collisions which I had to solve when I merged to this branch, but I think it should be ok....
@cicnavi I'm ready to merge this. I just want to confirm the target is wip-version-6
and do you have a preference between doing a squash commit or merge commit? I wasn't sure if you care about commit log noise. If no preference I'll make this a squash commit.
Yes, squash to v6.
218