search

simplesamlphp / simplesamlphp-module-oidc

A SimpleSAMLphp module for OIDC OP support.
Other
45 stars 22 forks source link

Make OIDC protocol endpoints available as Symfony routes #227

Closed cicnavi closed 2 months ago

cicnavi commented 2 months ago

This is a long-wanted move to use Symfony routing / container mechanism.

In this PR,, OIDC protocol related endpoints ('authorization_endpoint', 'token_endpoint', 'userinfo_endpoint', 'end_session_endpoint', 'jwks_uri') are made available as Symfony routes, as well as OP configuration endpoint (openid-configuration). New endpoints are now published in OP configuration endpoint by default.

Old routes served by PHP files in public (public/*.php) are still available and functional. I was thinking to leave them in v6, and remove them in v7 to make it easier for RPs to update the OP configuration.

@pradtke I think you should take a look. Also check with public client for CORS...

Unit tests will come later 💯

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 21.30178% with 133 lines in your changes missing coverage. Please review.

Project coverage is 52.99%. Comparing base (eb5232d) to head (14f0dc7).

Files Patch % Lines
src/Factories/RequestRulesManagerFactory.php 0.00% 26 Missing :warning:
src/Services/Container.php 0.00% 25 Missing :warning:
src/Bridges/PsrHttpBridge.php 0.00% 18 Missing :warning:
src/Services/ErrorResponder.php 0.00% 14 Missing :warning:
src/ModuleConfig.php 0.00% 11 Missing :warning:
src/Controller/AccessTokenController.php 44.44% 5 Missing :warning:
src/Controller/AuthorizationController.php 44.44% 5 Missing :warning:
src/Controller/UserInfoController.php 16.66% 5 Missing :warning:
src/Factories/AuthorizationServerFactory.php 0.00% 5 Missing :warning:
src/Server/Validators/BearerTokenValidator.php 68.75% 5 Missing :warning:
... and 9 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## wip-version-6 #227 +/- ## =================================================== - Coverage 54.23% 52.99% -1.25% - Complexity 1066 1101 +35 =================================================== Files 114 117 +3 Lines 3911 4029 +118 =================================================== + Hits 2121 2135 +14 - Misses 1790 1894 +104 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cicnavi commented 2 months ago

Thanks for letting me know. I'll go ahead and merge this as I need to continue working. Please check if everything is ok with public clients in v6 branch when you get the chance. Tny!