simplesamlphp / simplesamlphp-module-oidc

A SimpleSAMLphp module for OIDC OP support.
Other
45 stars 22 forks source link

Fix db migration other warnings #230

Closed pradtke closed 2 months ago

pradtke commented 2 months ago
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.99%. Comparing base (7231635) to head (b62d05f).

Files Patch % Lines
src/Services/DatabaseMigration.php 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## wip-version-6 #230 +/- ## ================================================ Coverage 52.99% 52.99% Complexity 1101 1101 ================================================ Files 117 117 Lines 4029 4029 ================================================ Hits 2135 2135 Misses 1894 1894 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pradtke commented 2 months ago

@cicnavi fyi: I mostly want you to be aware my change for detecting the database type. It makes it possible to test a docker image with sqllite + I think if we encounter a DB oddity with another database then we have something to base that on.

cicnavi commented 2 months ago

Ok, tny