simplesamlphp / simplesamlphp-module-statistics

The SimpleSAMLphp statistics module

GNU Lesser General Public License v2.1

2 stars 0 forks source link

Replace getPreferredTranslation with getEntityDisplayName #7

Closed thijskh closed 3 years ago

thijskh commented 3 years ago

Untested since I do not use this module, so needs verification by someone who does.

Closes: #5

codecov[bot] commented 3 years ago

Codecov Report

Merging #7 (23fd5b6) into master (43d5777) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff            @@
##             master      #7   +/-   ##
========================================
  Coverage      0.00%   0.00%           
+ Complexity      311     310    -1     
========================================
  Files            16      16           
  Lines           984     983    -1     
========================================
+ Misses          984     983    -1

tvdijen commented 3 years ago

Sep 4 21:32:51 webapp-10 simplesamlphp-idp[16242]: 3 [e69bb4b4e7] SimpleSAML\Error\Exception: Error 8 - Undefined index: name at /apps/installation/simplesamlphp/simplesamlphp-master/modules/statistics/lib/Statistics/FieldPresentation/Entity.php:20

Sep 4 21:32:51 webapp-10 simplesamlphp-idp[16242]: 3 [e69bb4b4e7] Caused by: TypeError: Argument 1 passed to SimpleSAML\XHTML\Template::getEntityDisplayName() must be of the type array, null given, called in /apps/installation/simplesamlphp/simplesamlphp-master/modules/statistics/lib/Statistics/FieldPresentation/Entity.php on line 20

tvdijen commented 3 years ago

Works like a charm!