search

simplesamlphp / simplesamlphp-module-webauthn

A module implementing FIDO2 / WebAuthn as a second authentication factor
GNU Lesser General Public License v2.1
15 stars 8 forks source link

Feature/sqlite #22

Closed tommy2d closed 4 years ago

tommy2d commented 4 years ago
tvdijen commented 4 years ago

Looking good!

tommy2d commented 4 years ago

Is there anything I need to do now in order to get this merged?

tvdijen commented 4 years ago

Nope, I just wanted to give others a chance to review

restena-sw commented 4 years ago

Since I don't use SQLite to try it out myself, I'm happy for @tvdijen to merge this.

restena-sw commented 4 years ago

We've just merged some changes to make Psalm happy. Can you rebase the code against current master? Thanks!

tvdijen commented 4 years ago

I took care of it already

codecov[bot] commented 4 years ago

Codecov Report

Merging #22 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##             master   #22   +/-   ##
======================================
  Coverage         0%    0%           
  Complexity      122   122           
======================================
  Files             7     7           
  Lines           433   433           
======================================
  Misses          433   433
Impacted Files Coverage Δ Complexity Δ
lib/WebAuthn/WebAuthnRegistrationEvent.php 0% <ø> (ø) 48 <0> (ø) :arrow_down:
lib/WebAuthn/Store/Database.php 0% <0%> (ø) 9 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8493309...4479805. Read the comment docs.

tommy2d commented 4 years ago

Great! I’m currently in Myanmar for a few weeks, without a device with a hardware keyboard, so rebasing would have been a pain.