simplesamlphp / simplesamlphp-module-webauthn

A module implementing FIDO2 / WebAuthn as a second authentication factor
GNU Lesser General Public License v2.1
15 stars 8 forks source link

Add Controllers + Controller-tests #31

Closed tvdijen closed 4 years ago

tvdijen commented 4 years ago

Closes #14

codecov[bot] commented 4 years ago

Codecov Report

Merging #31 into master will increase coverage by 14.98%. The diff coverage is 42.51%.

@@              Coverage Diff              @@
##             master      #31       +/-   ##
=============================================
+ Coverage      0.00%   14.98%   +14.98%     
- Complexity      138      204       +66     
=============================================
  Files             8       13        +5     
  Lines           480      734      +254     
=============================================
+ Hits              0      110      +110     
- Misses          480      624      +144     
restena-sw commented 4 years ago

I see that the commits to the PR are slowing down. Do you think this is now ready for merging, or are you still working on it?

tvdijen commented 4 years ago

Hi Stefan! This is as good as it gets with the unit tests without a lot of refactoring.. I could use a tester though! Especially the cache-headers need a proper test..

restena-sw commented 4 years ago

Hm. Since this is a rather complex change, and the code as it is pre-PR is known working and tested, how about the following:

?

tvdijen commented 4 years ago

Works for me!

restena-sw commented 4 years ago

I tested current master (including the code from this PR). It worked quite well: both basic login and the key management page worked as expected. I think we can consider this good enough.

tvdijen commented 4 years ago

Thanks, it's good to hear that hard work pays off! It's ready for SSP 2.0 now