Closed tvdijen closed 4 years ago
Merging #31 into master will increase coverage by
14.98%
. The diff coverage is42.51%
.
@@ Coverage Diff @@
## master #31 +/- ##
=============================================
+ Coverage 0.00% 14.98% +14.98%
- Complexity 138 204 +66
=============================================
Files 8 13 +5
Lines 480 734 +254
=============================================
+ Hits 0 110 +110
- Misses 480 624 +144
I see that the commits to the PR are slowing down. Do you think this is now ready for merging, or are you still working on it?
Hi Stefan! This is as good as it gets with the unit tests without a lot of refactoring.. I could use a tester though! Especially the cache-headers need a proper test..
Hm. Since this is a rather complex change, and the code as it is pre-PR is known working and tested, how about the following:
?
Works for me!
I tested current master (including the code from this PR). It worked quite well: both basic login and the key management page worked as expected. I think we can consider this good enough.
Thanks, it's good to hear that hard work pays off! It's ready for SSP 2.0 now
Closes #14