Disconnecting the client auto-closes all listeners

simplesteph / grpc-go-course

Companion Repository for my gRPC Golang course

http://bit.ly/grpc-golang-github

MIT License

473 stars 322 forks source link

Disconnecting the client auto-closes all listeners #18

Closed gkanchev-interview closed 3 years ago

gkanchev-interview commented 3 years ago

if you see grpc\server.go in func (s *Server) Stop() there is already code which closes all listeners on line 1648. Closing listeners manually can cause weird errors, especially if you do it after server stop

gkanchev-interview commented 3 years ago

Woops made PR from wrong account :D