search

simplesteph / kafka-connect-github-source

Get a stream of issues and pull requests for your chosen GitHub repository
https://links.datacumulus.com/kafka-connect-coupon
MIT License
447 stars 190 forks source link

Enhanced to support for multiple repositories #12

Open neeraj97 opened 4 years ago

neeraj97 commented 4 years ago

Changed to support for multiple repositories and topic (issue #2).

HttpClient is used for http calls. Did not create static HttpClient because HttpClient should be closed for freeing resources when no longer required , but HttpClient cannot be closed if static as there might be other task using it. So I used single HttpClient per task and is closed when task is stopped.

simplesteph commented 4 years ago

this is really nice thank you. I won't be able to merge this unfortunately as this wouldn't match the video content I recorded while creating this connector, but I'm happy if you want to leave the PR opened or create a fork for your own repository

neeraj97 commented 4 years ago

this is really nice thank you. I won't be able to merge this unfortunately as this wouldn't match the video content I recorded while creating this connector, but I'm happy if you want to leave the PR opened or create a fork for your own repository

Github has deprecated the username , password authentication and will soon not support it. kindly refer below : https://developer.github.com/changes/2020-02-14-deprecating-password-auth/ https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/ Just informing you to keep the video updated at that time.

simplesteph commented 4 years ago

you rock, thank you!

neeraj97 commented 4 years ago

you rock, thank you!

It's because you are my teacher