Open simplesteph opened 7 years ago
Hi Stephane , I would like enhance the connector to support for multiple repositories and I found few bugs in the connector , one in GitHubAPIHttpClient and other in poll() function of GitHubSourceTask. I would like to resolve them. Let me know if this project is still active so that I can submit PR.
I would suggest doing your own branch and doing a PR there. It’s not active anymore and it was made for instructional purposes
On Tue, Mar 3 2020 at 6:27 AM, neeraj97 < notifications@github.com > wrote:
Hi Stephane , I would like enhance the connector to support for multiple repositories and I found few bugs in the connector , one in GitHubAPIHttpClient and other in poll() function of GitHubSourceTask. I would like to resolve them. Let me know if this project is still active so that I can submit PR.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub ( https://github.com/simplesteph/kafka-connect-github-source/issues/2?email_source=notifications&email_token=AE7CW2JU2N22DN2ELFNN6XLRFSPMZA5CNFSM4DJIX542YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENSIHVI#issuecomment-593789909 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AE7CW2I5ZYW7YXJQNHM5UQ3RFSPMZANCNFSM4DJIX54Q ).
the cool thing with multiple repo is that we can track the API call limits from the same Http Client. We can also have multiple tasks (so maybe make the http client a singleton?), so we can introduce some level of parallelism. This would change the settings to maybe:
github.repos=repo/owner:topic,kubernetes/kubernetes:github-issues-kubernetes,apache/kafka:github-issues-kafka