search

simplewebrtc / signalmaster

simple socket.io server for webrtc signaling
Other
1.31k stars 486 forks source link

Crash in server.js #20

Closed danieleratti closed 10 years ago

danieleratti commented 10 years ago

I've noticed this crash in the last version that happens when i try to connect. I'm using a stun and a turn in this way:

"stunservers" : [ {"url": "stun:stun.l.google.com:19302"} ], "turnservers" : [ { url: 'turn:username@mydomain.net:19302?transport=udp', credential: '1234567890' } ]

this is the crash stack:

debug - websocket writing 5:::{"name":"stunservers","args":[[{"url":"stun:stun.l.google.com:19302"}]]}

crypto.js:226 this._binding.init(hmac, toBuf(key)); ^ TypeError: Not a buffer at new Hmac (crypto.js:226:17) at Object.Hmac (crypto.js:224:12) at /Users/danieleratti/Dropbox/SERVERS/WebRTC/Part2/signalmaster-master/server.js:104:31 at Array.forEach (native) at SocketNamespace. (/Users/danieleratti/Dropbox/SERVERS/WebRTC/Part2/signalmaster-master/server.js:103:28) at SocketNamespace.EventEmitter.emit as $emit at connect (/Users/danieleratti/Dropbox/SERVERS/WebRTC/Part2/signalmaster-master/node_modules/socket.io/lib/namespace.js:292:10) at /Users/danieleratti/Dropbox/SERVERS/WebRTC/Part2/signalmaster-master/node_modules/socket.io/lib/namespace.js:308:13 at SocketNamespace.authorize (/Users/danieleratti/Dropbox/SERVERS/WebRTC/Part2/signalmaster-master/node_modules/socket.io/lib/namespace.js:252:5) at SocketNamespace.handlePacket (/Users/danieleratti/Dropbox/SERVERS/WebRTC/Part2/signalmaster-master/node_modules/socket.io/lib/namespace.js:302:14)

danieleratti commented 10 years ago

I solved by inserting the TURN server in the STUN field but still not understanding the issue:

"stunservers" : [ {"url": "stun:stun.l.google.com:19302"}, { url: 'turn:username@mydomain.net:19302?transport=udp', credential: '1234567890' } ], "turnservers" : [ ]

fippo commented 10 years ago

when you insert the TURN server as a stun server, no password will be generated... did you update to https://github.com/andyet/signalmaster/commit/4c94ff7329bd0995a61706fb192841de1500d977 before this happened?

fippo commented 10 years ago

ah... the code assumes that you want to use the shared secret mechanism for TURN -- if you dont use that, putting your turn server into the STUN section should work.

danieleratti commented 10 years ago

Ok i understood. Thanks