Added the ability to use an existing express server

simplewebrtc / signalmaster

simple socket.io server for webrtc signaling

Other

1.31k stars 486 forks source link

Added the ability to use an existing express server #44

Closed shichongrui closed 9 years ago

robschley commented 9 years ago

Any plans to merge this PR?

bear commented 9 years ago

apologies for the delay in responding...

We love the idea of moving the socket handling code into sockets.js so that it's easier to add/expand the code but we really do not want to start adding each framework's server to the code base because we want it to be as generic as possible.

Would you mind altering the PR so that it just doesn't have the express.js part? That part would be in your code base.

thanks

shichongrui commented 9 years ago

Updated

bear commented 9 years ago

thanks - let me review this and get a final +1 from another of our devs...

felipebrahm commented 9 years ago

@bear could you publish this to the npm registry as a new version? thanks!