search

simplewebrtc / signalmaster

simple socket.io server for webrtc signaling
Other
1.31k stars 485 forks source link

Option log level is not valid #52

Open modder2 opened 8 years ago

modder2 commented 8 years ago

In socket.io 1.3.7 logging was changed. http://socket.io/docs/logging-and-debugging/ This code in deprecated:

if (config.logLevel) {
    // https://github.com/Automattic/socket.io/wiki/Configuring-Socket.IO
    io.set('log level', config.logLevel);
}

On run server output this:

Option log level is not valid. Please refer to the README.

Please fix it.

xdumaine commented 8 years ago

please fix it.

Pull requests are welcome.

atsoy commented 8 years ago

As workaround run in console: $ DEBUG=* NODE_ENV=production node server.js

TheChuckster commented 7 years ago

Pull requests are welcome.

This is an incredibly user hostile anti-pattern that I'm sad to keep seeing crop up again and again in the open source world.

https://news.ycombinator.com/item?id=8134590

xdumaine commented 7 years ago

@TheChuckster the creator of this issue had a history of making demands of the maintainers of this project and the related repositories, without ever showing any effort to contribute to the projects, so his demand to just "please fix it" was met with a request to contribute to the project himself. That said, I'm not sure what you're looking to gain by posting that here. Are you encountering this issue as well?

chuckhacker commented 7 years ago

Actually, I was, but in the interest of time, I just commented it out as a workaround.

I really do appreciate your work, and it looks like there might have been some aspects of the situation that I may have overlooked. Not trying to gain anything here other than that I just want to see the open source community continue to thrive in the best ways possible.