Updated to Socket.IO v1 api in case of active signalmaster's maxClients configuration

simplewebrtc / signalmaster

simple socket.io server for webrtc signaling

Other

1.31k stars 486 forks source link

Updated to Socket.IO v1 api in case of active signalmaster's maxClients configuration #57

Open scotu opened 8 years ago

scotu commented 8 years ago

Just a trivial fix for Socket.IO v1, I encountered the bug using maxClients in the config. I wasn't sure if it's good to return 0 if the room is not valid (because I'm not sure how it can happen that is not valid).

Let me know if I need to adjust anything.

(Thanks for signalmaster, btw :D)

scotu commented 8 years ago

My "fix" was indeed wrong. I updated the pr, I also noticed that to get the room, in other functions in signalmaster, the namespace was selected manually, so I went that way also here.

Let me know any further problems or requirements

Thanks