Fix: Server crash after second user joined

simplewebrtc / signalmaster

simple socket.io server for webrtc signaling

Other

1.31k stars 486 forks source link

Fix: Server crash after second user joined #62

Closed CapsE closed 8 years ago

CapsE commented 8 years ago

Fixed an error where the server would crash after a second user joined a room.

AlphaHinex commented 8 years ago

Nice job! But too many files changed in this PR and they are useless. The only valuable change is in sockets.js. Maybe you need to clean up before merge.

CapsE commented 8 years ago

Yeah sorry about that. I think my changes might have been wrong in the first place.

I integrated the server into my existing express app and had to revert the changes I made to the code to get it to work again. I guess I just fixed some symptoms and not the problem with my fix.

AlphaHinex commented 8 years ago

Maybe you need to update the version of socket.io-client too. I did similar changes as yours and it works now. See custom signal master server and source.

fippo commented 8 years ago

that should be fixed with #65 now