search

simplewebrtc / signalmaster

simple socket.io server for webrtc signaling
Other
1.31k stars 486 forks source link

maxClients > 0 configuration doesn't fail now #77

Open ulshv opened 8 years ago

ulshv commented 8 years ago
  1. Change deprecated 'io.sockets.clients' in clientsInRoom() to another function.
  2. Update socket.io-client to latest version (1.4.5). Previous version (0.9) fails in Node v.4.x (because of nan). Ran test.js - everything ok.
  3. Also made some small fixes.
yannleretaille commented 7 years ago

this is a big issue affecting many users, see #97, #79, #76 @andyetOps: any way for you to merge this and the other pull requests?

Ingeniousmeet commented 7 years ago

On 06-Apr-2017 8:44 PM, Yann notifications@github.com wrote:this is a big issue affecting many users, see #97, #79, #76 @andyetOps: any way for you to merge this and the other pull requests?

—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

bobbytes commented 6 years ago

What's the status of this PR?

pirate commented 6 years ago

Any update on this PR?

yasithph commented 5 years ago

Tried changing the socket.io-client to latest version (1.4.5) and changed the lines 'io.sockets.clients' in sockets.js to the ones in the PR and it worked. This fixed the major issue 'fn.bind is not a function which was result of the deprecated 'io.sockets.clients'. Thanks @ulshv