search

simplexspatial / osm4scala

Scala and Spark library focused on reading OpenStreetMap Pbf files.
https://simplexspatial.github.io/osm4scala/
MIT License
81 stars 18 forks source link

Expose info fields #67

Closed ericsun95 closed 4 years ago

ericsun95 commented 4 years ago

Fixes #40 Expose all optional info fields listed here to PBFIterator and SparkConnector: 

message Info {
   optional int32 version = 1 [default = -1];
   optional int32 timestamp = 2;
   optional int64 changeset = 3;
   optional int32 uid = 4;
   optional int32 user_sid = 5; // String IDs
   optional bool visible = 6;
}

Will add more integration test when exporting PBF/XML is available. Create a ticket for adding bbox info if needed in future.

Reference:

  1. https://wiki.openstreetmap.org/wiki/PBF_Format
  2. https://github.com/openstreetmap/osmosis/blob/2219470cef1f73f5d1319c57149c84b398e767ce/osmosis-pbf2/src/main/java/org/openstreetmap/osmosis/pbf2/v0_6/impl/PbfFieldDecoder.java
  3. https://github.com/openstreetmap/osmosis/blob/2219470cef1f73f5d1319c57149c84b398e767ce/osmosis-pbf2/src/main/java/org/openstreetmap/osmosis/pbf2/v0_6/impl/PbfBlobDecoder.java
coveralls commented 4 years ago

Coverage Status

Coverage decreased (-6.8%) to 86.119% when pulling 5f93ae9e06680b20a912c231835fa74901c84536 on ericsun95:master into f2b868271ca42bf797c8c8784a130d718cd67601 on simplexspatial:master.

angelcervera commented 4 years ago

I can not accept this PR. Looks like you can not wait for a proposal and talk from there, and your design and quality criteria are too different from mine.

So in this case, looks like is not going to be possible to collaborate. Please, no more privates messages.