simplicialsoftware / nebulous-translations

The sole purpose of this repository is to allow Nebulous players to collectively improve the translated text used in Nebulous.io.
https://www.simplicialsoftware.com
Other
28 stars 344 forks source link

Update values (English) #892

Open Jeiii20 opened 3 weeks ago

Jeiii20 commented 3 weeks ago

ℹ️ About this PR

This PR contains changes to the English language that I found interesting to make and to improve readability for English speakers at all. Referral to PR #881.

⚙️ Changes

➕ Plus

<string-array name="languages">

➕ Additional description

Change requests are greatly welcomed and appreciated. Therefore, if there is really any meaningful change to be made, I will surely make it, so please do not hesitate on it.

AnkaKoxu commented 2 weeks ago

I looked and I guess I need to book a slot here, something from me soon 😉

AnkaKoxu commented 2 weeks ago

Your pr Jei is very bravely and contains quite good changes in terms of understanding some of the content, more specific and concrete information has been added, which is a plus.

[💡] Consider these changes

834

The pr omits the absolutely most important string to correct (834), which begins with a capital letter, which is unnecessary because it is attached to the next sentence.... “The next tournament Starts in 60 seconds.” I would suggest a change:

<string name=“starts_In”>starts in</string>

According to this, the sentence would read: “The next tournament starts in 60 seconds".

80 81

Omitted also an important thing to correct.... Strings 80 and 81, with the minimum and maximum number of players. <string name=“Max_Players”>“Max Players”</string>

<string name=“Min_Players”>“Min Players”</string>

Min and Max should be preceded by a period because it is an abbreviation. <string name=“Max_Players”>“Max. Players”</string>

<string name=“Min_Players”>“Min. Players”</string>

435

It seems to me that the message also pops up in the case of a purchased pack and this fact was omitted. As for the item, yes, I agree that it would be legitimate in the form of skins, pets, etc., but it is not a hit wording in the case of buying a pack (which is not an item in itself). purchased I would leave it as it is.

786

If you put it together this way, a colon is necessary before enumerating skins

899

In this string, it seems to me that the dev's intention was to be as economical as possible, and I think we should stick to that, especially since the in-game space for this string is severely limited, btw, see how it looks in Polish. One line holds up to 6 characters. clan You have ALL FROM, which is 8 characters (with space) clany And I'm afraid Nebulous just won't withstand it xD I would suggest leaving it as it is now...

765

It was the first time I noticed the word "Threshold" in this context. And yes, I like more “Compression” than “Threshold” I did a lot of research.... image treshold involves converting a grayscale kub color image into a binary (black and white) image. Compression is the process of reducing the file size and the goal is to reduce the amount of space needed to store the image, wwhich fits the context better. You will find many tutorials on tresholding and yes, they all change the color, so it must be true xD So I say, I would leave it as it is, which is Image Comppresion, the threshold might not be hit-word here. Thresholding threshold

[🧠] Suggestions / My thoughts

148, 150

You are probably prepared for voices of protest.... NO, NO, NO. ffa Do you really think it will make really huge difference? It's going to be the same e.g. in Polish, whether it's FFA TIME or FFA TIMED. We even talked about it, but I don't think I'm personally ready for such a change. And I never will be XD As we talked you said that if it was FFA TIMED it would be too long to translate even in your language.... xD I don't even know what to say, I personally consider this not necessarily an essential change.

If this would be merged, I will definitely undertake the translation from 0, the pr is very promising.

Jeiii20 commented 2 weeks ago

Thanks for your feedback, @AnkaKoxu!!