simplicityitself / grails-gwt

New Grails GWT Plugin
Other
23 stars 18 forks source link

Fixed GWTP find modules bug #29

Closed donbeave closed 10 years ago

donbeave commented 10 years ago

Before findModules return 0 if project use GWTP (https://github.com/ArcBees/GWTP) library.

daviddawson commented 10 years ago

Whats the problem that this fixes?

donbeave commented 10 years ago

This is example of typical GWTP App.gwt.xml:

<?xml version="1.0" encoding="UTF-8"?>
<module rename-to="testapp">
  <inherits name="com.google.gwt.user.User"/>
  <inherits name="com.gwtplatform.mvp.MvpWithFormFactor"/>

  <!-- Form factor specific modules -->
  <set-configuration-property name="gin.ginjector.module.desktop"
                              value="com.site.testapp.client.gin.DesktopModule"/>
  <set-configuration-property name="gin.ginjector.module.mobile"
                              value="com.site.testapp.client.gin.MobileModule"/>
  <set-configuration-property name="gin.ginjector.module.tablet"
                              value="com.site.testapp.client.gin.TabletModule"/>

  <!-- Shared modules -->
  <extend-configuration-property name="gin.ginjector.modules"
                                 value="com.polusharie.client.gin.SharedModule"/>
</module>

In GWTP you don't need to specify entry point, just need to inherit MvpWithEntryPoint or MvpWithFormFactor: https://github.com/ArcBees/GWTP/wiki/Bootstrapping-or-Application-Initialization#entrypoint

But Grails GWT now find modules by checking entry point in App.gwt.xml, so it return 0 if you use GWTP standard way.

daviddawson commented 10 years ago

Great. sounds good.

donbeave commented 10 years ago

Yeah. In fact GWTP really cool library to create complex web apps. :-)