search

simplicityitself / grails-gwt

New Grails GWT Plugin
Other
23 stars 18 forks source link

Added support define args only to compilation process #33

Closed donbeave closed 10 years ago

donbeave commented 10 years ago

Hi, David!

I added support of gwt.compile.args configuration option.

It need to spit up args between run and compile processes:

gwt.compile.args = {
//  arg(value: '-strict')
  arg(value: '-XdisableClassMetadata')
  arg(value: '-XdisableCastChecking')
  arg(value: '-XenableClosureCompiler')
}

gwt.run.args = {
  jvmarg(value: '-Xms1024m')
  jvmarg(value: '-Xmx2048m')
}

It needs to fix fail problem when you start run-gwt-codeserver with all above listed parameters defined in one gwt.run.args. Because com.google.gwt.dev.codeserver.CodeServer doesn't support all of these parameters, like -XdisableClassMetadata, -XdisableCastChecking, ...

daviddawson commented 10 years ago

That's great!

Would you mind awfully updating the documentation with this new option?

Then I'll merge it straight into the 0.9.x and 1.0 branches.

confile commented 10 years ago

Could you please release a new version of the plugin with this feature?

donbeave commented 10 years ago

Thanks @daviddawson I will update documentation with this new option.

daviddawson commented 10 years ago

@donbeave Hey dude. don't worry, I've just done the update to get it out of the door.

Thanks for the feature! :-)

daviddawson commented 10 years ago

@confile @donbeave 0.9.3 is released with this feature merged in.

confile commented 10 years ago

great thank you!

confile commented 10 years ago

Do I have to use it like this?

gwt.compile.args = {
    //  arg(value: '-strict')
      arg(value: '-XdisableClassMetadata')
      arg(value: '-XdisableCastChecking')
      arg(value: '-XenableClosureCompiler')
}

gwt.run.args = {
    jvmarg(value: '-Xms1024m')
    jvmarg(value: '-Xmx2048m')
}

gwt {
    version="2.5.1"

dependencies=[
        'com.google.gwt.inject:gin:2.1.1' ]
}
donbeave commented 10 years ago

The better if you specify GIN dependency by standard way (from plugin documentation), because gin depends on some libraries, and plugin can automatically download them all.

gwt.compile.args = {
  arg(value: '-XdisableClassMetadata')
  arg(value: '-XdisableCastChecking')
  arg(value: '-XenableClosureCompiler')
}

gwt.run.args = {
  jvmarg(value: '-Xms1024m')
  jvmarg(value: '-Xmx2048m')
}

gwt {
  version = '2.5.1'
  gin.version = '2.1.2'
}

I just pulled new request that contain fix for GIN versions >= 2.1 https://github.com/simplicityitself/grails-gwt/pull/36

confile commented 10 years ago

Could you please update the grails plugin release for that last commit