search

simplicityitself / grails-gwt

New Grails GWT Plugin
Other
23 stars 18 forks source link

added support for Super Dev Mode using GWT > 2.5.0 #56

Closed jwueller closed 10 years ago

jwueller commented 10 years ago

Super Dev Mode works with GWT > 2.5.0, but only 2.5.0 was allowed. A more generalized version check is used to ensure compatibility now and in future versions.

jwueller commented 10 years ago

Correction: This is for GWT > 2.5.x.

Also fixes potential issue with multi-digit version components.

confile commented 10 years ago

@jwueller What does this fix do? I use grails-gwt with GWT 2.6.0 and super dev mode all the time with no problems

jwueller commented 10 years ago

@confile addGwtCoreToDependencies() previously didn't add these dependencies for GWT > 2.5.x:

addDependency("com.google.gwt", "gwt-codeserver", version)
addDependency("org.json", "json", "20090211")

because of this version check:

if (version.startsWith("2.5")) {

causing the availability check for com.google.gwt.dev.codeserver.CodeServer to fail. This, in turn, triggered the following false-negative:

Super Dev Mode only support in GWT 2.5.0 version

effectively breaking Super Dev Mode for everyone using GWT 2.6.0 or similar by refusing to start.

As to why you are not experiencing this problem: This issue would not occur if you manually added the codeserver to your classpath. Is that possibly what you are using in your setup?

confile commented 10 years ago

I use an external GWT project which uses a Grails project as host project. So yes you are right I guess.