search

simplicityitself / grails-gwt

New Grails GWT Plugin
Other
23 stars 18 forks source link

Gpgwt 74 plugin modules #8

Closed johnrellis closed 12 years ago

johnrellis commented 12 years ago

Hey David,

I simply added some lines of code to _GwtInternal to make it possible to include gwt source from plugins defined in BuildConfig.groovy

gwt { local.workers = 3 plugins = ['reporting'] run.args = { jvmarg(value: '-Xmx1024m') } }

It does not fill the request of including the "SomeGwtLibrary.jar" that we talked about in our email thread, just the source code.

PluginApp SomeGwtLibrary.jar src/gwt/SomeClass.java

Secondly, the dto plugin is still handled separately as the .gwt.xml file for this is in the GWT plugin itself which I find a little confusing. If you want to handle the dto plugin the same as the rest I can definitely change the code to try that (if possible without breaking the dto plugin)

dawsonsystems commented 12 years ago

I think we can split the lib question to be a different problem as the dependency management will need revisiting at some point anyway. Similar with the dto plugin, I wouldn't want to break functionality for anyone using it already, so lets leave the auto detection where it is.

I'm going to clean up a few of the outstanding issues and make a new release over the next couple of days, this will make a great addition (probably the most important!)

Thanks!

dawsonsystems commented 12 years ago

Once I have the other fixes ready i'll merge them all to master and release, so this pull will remain open for now.

johnrellis commented 12 years ago

Great. I will keep an eye out as this is needed for my current project in work. I am using the locally built plugin in my current project and it is humming away. Thanks for help with my first possible commit :)

johnrellis commented 12 years ago

Also if I can add to the docs if they exist??