simplifiedcourses / ngx-vest-forms

Simple form development for complex and scalable solutions
34 stars 2 forks source link

[Suggestion] Use `ngx` as prefix instead of `sc` #7

Open the-ult opened 3 days ago

the-ult commented 3 days ago

Hey Brecht,

I know sc is the prefix of Simplified Courses, but I think the library will be used more if the prefix is a bit more global/less tied to Simplified Courses.

Also it would seem more logic, since the library name is ngx-vest-forms

So suggestions for a new prefix:

I like ngx the most 😇

I'm willing to create a PR (and might try to provide a schematic as well, since it is a breaking change)

simplifiedcourses commented 3 days ago

Hi There!

I'm not against changing the suffix, after all it's about helping people. some thoughts:

the-ult commented 3 days ago

The lib is still not widely used, so maybe this is the time.

Yeah, was thinking the same thing.

I believe the suffix should be unique, I think that's the idea of a suffix. Would ngx be unique enough? since it is the standard for angular libraries?

Don't know if ngx is unique enough. But on the other hand. You probably won't have multiple libraries installed with the ngx prefix, that have the same kind of form directives/components.. 🤔