added proxy support - Githubissues

simpligility / maven-repository-tools

Tools for interacting with Maven repositories

Eclipse Public License 1.0

141 stars 69 forks source link

added proxy support #20

Closed rzabini closed 9 years ago

rzabini commented 9 years ago

Hi, here are two proposed changes:

a small fix to avoid a NullPointerException in replaceAll in case the config password is null
enable http proxy in downloading dependencies from a remote repository. Proxy is configured through the standard Java system properties:
- http.proxyHost
- http.proxyPort
- http.proxyUser
- http.proxyPassword

I needed to upgrade httpclient to version 4.3.4 (otherwise an exception is raised). Tested with Squid on Windows (with and without authentication)

mosabua commented 9 years ago

Excellent. Thanks for the contribution.

mosabua commented 9 years ago

I had to change all the code style for the build to pass .. ideally next time you can ensure it builds ;-)

mosabua commented 9 years ago

Want to provide some documentation for that as part of the command line call? Also ... I kind of feel like it might be better to allow them to be configured via the API call or via a parameter like the rest. wdyt?

rzabini commented 9 years ago

Hi, sorry for the mistypings, I just tested and ran the code in my IDE, so I was not aware of the code style.

I considered the option to use command line parameters, but then decided to use the system properties because they are a standard, as mentioned in the official Java documentation. Setting these properties when running behind a proxy would be the first thing a user would try (at least this was the first thing I tried), and so I chose a "least surprise" approach.

So if you agree, I would just add in the README a note like "if you are behind a proxy, set system properties as mentioned in Java Networking Properties"