Wrong classpath entry in manifest

simpligility / maven-repository-tools

Tools for interacting with Maven repositories

Eclipse Public License 1.0

137 stars 66 forks source link

Wrong classpath entry in manifest #44

Closed joehni closed 5 years ago

joehni commented 5 years ago

Hi,

when generating the maven-repository-provisioner-*-jar-with-dependencies.jar you add the classpath of all dependencies to the manifest, but this is wrong. Either you use the dependency plugin to collect all jars - then the classpath entry in the manifest must match the (relative) location to this collection - or you drop the classpath entry, since you currently merge all classes together in one big jar.

Cheers, Jörg

mosabua commented 5 years ago

Fair point. I will drop the classpath .. probably in the work towards the next release in the next week or two (hopefully). A PR would also be appreciated ;-)

joehni commented 5 years ago

C'mon, it's a single line:

diff --git a/maven-repository-provisioner/pom.xml b/maven-repository-provisioner/pom.xml
index 4ade433..7376c81 100644
--- a/maven-repository-provisioner/pom.xml
+++ b/maven-repository-provisioner/pom.xml
@@ -120,7 +120,6 @@
           <archive>
             <index>true</index>
             <manifest>
-              <addClasspath>true</addClasspath>
               <mainClass>com.simpligility.maven.provisioner.MavenRepositoryProvisioner</mainClass>
             </manifest>
           </archive>

:-D

mosabua commented 5 years ago

thx .. I guess you beat me to it.