Remove `PYTEST_VERSION` constant to work with pytest pre-releases

simplistix / sybil

Automated testing for the examples in your documentation.

https://sybil.readthedocs.io/en/latest/

Other

74 stars 14 forks source link

Remove `PYTEST_VERSION` constant to work with pytest pre-releases #143

Closed Zac-HD closed 2 weeks ago

Zac-HD commented 2 weeks ago

https://github.com/simplistix/sybil/blob/a06c1646e3545cc1fb221ce9faf36f5ea105be8a/sybil/integration/pytest.py#L21

This breaks for pre-release Pytest versions, with errors like ValueError: invalid literal for int() with base 10: 'dev127+g5d3a3ac02'. I was going to suggest pytest.version_tuple, but it looks like PYTEST_VERSION is entirely unused and could thus be deleted without replacement.

cjw296 commented 2 weeks ago

Yeah, it's currently unused, but pytest like breaking APIs that Sybil needs to work, so thanks for the pointer to version_tuple, I'll use that next time that crops up.

Do you need a release for this?

Zac-HD commented 2 weeks ago

A release would be much appreciated! I'll be installing from the commit until then 😅

cjw296 commented 1 week ago

Released in 8.0.1.