search

simplyWiri / Loadout-Compositing

GNU Lesser General Public License v3.0
12 stars 8 forks source link

Updated to work for Rimworld 1.5 #85

Closed ArchimedesNein closed 5 months ago

ArchimedesNein commented 6 months ago

Added 1.5 compatibility. Update was mostly straightforward, the biggest thing was the removal of the MeleeArmorPenetration StatDef, thus the new class.

ticcedtac commented 6 months ago

Hey! Thanks for doing this. LGTM. Seems to work fine with just this and Hugslib enabled.

There does seem to be some mod incompatibility, but I don't have time to go through my mod list right now and figure out what it is. A lot of my mods are technically outdated, but were working fine in 1.4. One of those could very easily be the cause. I'll try to figure it out when I get some time

With all of my mods:

  1. The buttons are missing from pawn gear screens.
  2. Using keybinds I can open the tag editor, but the list of items and list of pawns is missing from the right.
  3. The per-pawn tag popup won't open, even using a keybind.

Here's my mod list. I just loaded my save mod list, so it has a third party "continued" version of Compositable Loadouts in it, but I tested with that disabled and this branch enabled. All.rml.txt

I'm not at all familiar with Rimworld modding, but this looks like it could be a related issue in the Harmony log. I just did a search for "loadout" and this was the only reference, other than listing this mod as an installed mod.

System.NullReferenceException: Object reference not set to an instance of an object
[Ref D9CA7FC0]
 at <0x4136df80 + 0x000fb> <unknown method>
 at Inventory.LoadoutManager.GameComponentOnGUI () [0x00103] in <161c00cb4e82434c860e5f84721eecdf>:0 
 at Verse.GameComponentUtility.GameComponentOnGUI () [0x00017] in <869ae09cd42e4958ad76d610931cb571>:0  
(Filename: ./Runtime/Export/Debug/Debug.bindings.h Line: 39)
simplyWiri commented 5 months ago

Thanks, merged bits of this in https://github.com/simplyWiri/Loadout-Compositing/pull/83 - really appreciate it guys!