search

simplyvikram / google-chartwrapper

Automatically exported from code.google.com/p/google-chartwrapper
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

No HTTPS support #40

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Add chart to Django template as an image
2. Open page via HTTPS
3. Check the source URL of generated image

What is the expected output?

    I expect generated image to refer to HTTPS image so whole page is secure.

What do you see instead?

    Generated image uses http://chart.apis.google.com/ as prefix. E.g. generated URL do not respect current protocol.

Please provide any additional information below.

    Please make it work with HTTPS as well. I see 3 ways here:

1) Add a way to override APIURL in django settings (i.e. use django settings 
first).
2) Add a "secure" flag to chart template tag so program can pass if he needed 
secure URL or not
3) Change chart template tag so it automatically change it to HTTPS if request 
was made over HTTPS.

Original issue reported on code.google.com by ton...@gmail.com on 8 Oct 2012 at 9:32

GoogleCodeExporter commented 9 years ago 
4) Generate URL without schema, e.g. //chart.apis.google.com

Original comment by ton...@gmail.com on 8 Oct 2012 at 9:34