simrail / EDR

EDR timetable & driver view for Simrail
https://edr.simrail.app
GNU General Public License v3.0
25 stars 12 forks source link

Wrong 'To line' showing in EDR #95

Open IKatsu opened 1 year ago

IKatsu commented 1 year ago

I noticed that there are a few stations where the EDR will be showing the wrong line where the train has to go. Simrail's own SEPE SR will show the correct line so I'm assuming there is a parsing problem somewhere.

The main station where I notice this a lot is 'Grodzisk Mazowiecki', I think there's another one but I forgot which one it is. EDR simrailEDR

I'm not sure what criteria cause it to not work, Katowice for example works just fine.

firleju commented 10 months ago

Problem lies in that in Poland sometimes line number cange is calculated from switches. On screen above you have the same station with R. That is beacuse in schedules there are entries with suc places with line number change. Official EDR do not account such places.

MrDj200 commented 9 months ago

I don't think this is fixed. image this shows Line: 62 Whereas the official one says image Line no. 660

Tallyrald commented 9 months ago

I'm having a hard time deciding what is the actual line that needs to be displayed. From the API it is clear that the next station (in this case Sosnowiec Południowy) is on line 62, but it IS true that the dispatch point (Sosnowiec Gł. pzs R52) is on line 660. In the fix that is implemented for the current version I display the next point's line number which is 62. Is this how it should be? If it is then the official EDR is wrong for this train.

{
        "indexOfPoint": 6,
        "nameForPerson": "Sosnowiec Gł. pzs R52",
        "pointId": "3991",
        "displayedTrainNumber": "42940",
        "arrivalTime": "2023-11-25 10:51:00",
        "actualArrivalTime": null,
        "departureTime": "2023-11-25 10:51:00",
        "actualDepartureTime": null,
        "isStoped": false,
        "stopDuration": 0,
        "isActive": true,
        "isConfirmed": false,
        "confirmedBy": 0,
        "plannedStop": 0.0,
        "timetableType": 1,
        "stopTypeNumber": 0,
        "leftTrack": false,
        "line": 660,
        "platform": null,
        "track": null,
        "trainType": "ROJ",
        "mileage": 1.117,
        "maxSpeed": 30
      }
{
        "indexOfPoint": 7,
        "nameForPerson": "Sosnowiec Południowy",
        "pointId": "4010",
        "displayedTrainNumber": "42940",
        "arrivalTime": "2023-11-25 10:55:00",
        "actualArrivalTime": null,
        "departureTime": "2023-11-25 11:00:00",
        "actualDepartureTime": null,
        "isStoped": false,
        "stopDuration": 0,
        "isActive": true,
        "isConfirmed": false,
        "confirmedBy": 0,
        "plannedStop": 5.0,
        "timetableType": 1,
        "stopTypeNumber": 1,
        "leftTrack": false,
        "line": 62,
        "platform": "I",
        "track": 1,
        "trainType": "ROJ",
        "mileage": 82.732,
        "maxSpeed": 60
      }
Tallyrald commented 9 months ago

I actually think that the issue is that we display waypoints too and in some cases the waypoint is on a different line than the next station which is displayed on the official EDR. For this to be fixed we need a reliable way of telling a waypoint apart from a station (or dispatch post). The trick is that we need to do this without breaking Sosnowiec Gł. pzs R52...

MrDj200 commented 9 months ago

I'm not sure how it should be. I'm new to the game and don't know anything about dispatching. I just noticed that it seemed to be wrong when my neighboring station told me I sent a train on the wrong line. I had sent the train according to the website.