sims-lab / pipeline_rnaseq_hisat2

A pipeline for processing RNA-seq data using cgatcore and HISAT2.
0 stars 1 forks source link

Refine checks on output of CI #19

Open kevinrue opened 2 years ago

kevinrue commented 2 years ago
kevinrue commented 2 years ago

A few issues before moving forward with this, if moving forward at all:

I argue that seeing the pipeline make full complete without error during the GitHub Action workflow is already in itself confirmation that all the key intermediate files tracked by Ruffus were successfully generated, and did not cause any error in downstream steps. At that point, a reasonable CI strategy could include:

After all, CI checks are meant to ensure that software is functional, not that it is overfitted to produce one particular output. (yes, unit tests often check that code produces a particular output, but that's when the software is designed to return 4 when you ask for 2+2, what I'm saying here is that a pipeline is not designed to produce files with absolutely stable contents, or map reads systematically in the same way for every version of the mapping software, what matters is that the pipeline still runs to completion for the latest version of its dependencies, the rest is benchmarking and optimisation).