Added id to field identifier key

simsalabim / sisyphus

Gmail-like client-side drafts and bit more. Plugin developed to save html forms data to LocalStorage to restore them after browser crashes, tabs closings and other disasters.

http://sisyphus-js.herokuapp.com

MIT License

1.99k stars 221 forks source link

Added id to field identifier key #122

Closed twolfson closed 9 years ago

twolfson commented 9 years ago

As discussed in #121, we (@underdogio) has a use case that requires id support for fields that aren't being sent to the server. In order to address this, we have added id support to all field identifiers as well as a delimiter to prevent potential crossover.

In this PR:

Added common getElementIdentifier resolver
Updated all id/name resolvers to use getElementIdentifier
Updated multiple name logic (e.g. checkboxes[]) to support name not existing
Updated tests

simsalabim commented 9 years ago

@twolfson could you please rebase your branch off recent master?

twolfson commented 9 years ago

@simsalabim I have merged, squashed, and rebased with the latest master

simsalabim commented 9 years ago

Thanks!