search

simsalabim / sisyphus

Gmail-like client-side drafts and bit more. Plugin developed to save html forms data to LocalStorage to restore them after browser crashes, tabs closings and other disasters.
http://sisyphus-js.herokuapp.com
MIT License
1.99k stars 221 forks source link

Works partially with Tinymce3, not at all with Tinymce4 #129

Open bartclaeys opened 9 years ago

bartclaeys commented 9 years ago

Can someone confirm whether sisyphus.js supports Tinymce3 or Tinymce4? From my tests it works partially with Tinymce3, but not at all with Tinymce4.

What I mean with 'partially' is that the Tinymce3 editor field is only saved when other fields of the same form are being edited. If the only thing you manipulate in the form is the Tinymce3 field, then these changes are not saved. It's seems like some kind of binder has not attached successfully to the Tinymce3 textfield.

I'm not very interested in sisyphus.js to support Tinymce3, but wonder what architecturally changed in Tinymce4 making it not work at all.

simsalabim commented 9 years ago

What is common for WYSIWYG editors is replacing input fields with divs/other elements and creating a shadow copy of original field; then content in div is synchronized with shadow field. What changed is probably they added more shadowing. This is all speculations as I am not a user of of TinyMCE.

bartclaeys commented 9 years ago

This commit https://github.com/simsalabim/sisyphus/pull/111 makes sisyphys.js work with Tinymce4.

simsalabim commented 9 years ago

Awesome! When the author has addressed comments and rebased from current master it will be merged.

andresteves commented 6 years ago

It is not working anymore with new version of Tinymce

simsalabim commented 6 years ago

Old news. The latest stable version of Tinymce as of now is 4.5.7, and as the title of the issue says, "Works partially with Tinymce3, not at all with Tinymce4".