Closed jgru closed 3 years ago
Strangely, though, the action didn’t run n the PR. Perhaps because you are not a maintainer?
Strangely, though, the action didn’t run n the PR. Perhaps because you are not a maintainer? I think so. I hope, that anything runs fine now!
Still not compiling?
https://github.com/simsong/bulk_extractor/runs/2912238640?check_suite_focus=true
Perhaps we should just mandate the current json-c? How can we force the current version?
Still not compiling?
https://github.com/simsong/bulk_extractor/runs/2912238640?check_suite_focus=true The error stems from the line 65 of the previous commit, which was removed by this PR. The compile error occurs at
end = json_tokener_get_parse_end(jt);
, which is not part of this PR anymore.
Can you skip the compilation of the previous PR and restart it with the new codebase formed by commit 2db7b97e7b7baaaec05a716557e9da20c5c8c8a4?
Perhaps we should just mandate the current json-c? How can we force the current version? I would try to get a compile run of the PR, which should fix the issue, since this should work with 0.13 flawlessly.
Thanks!
Let me try that....
Dear Simson,
this PR fixes a compilation issue introduced by #170, which stemmed from using a function named
json_tokener_get_parse_end(...)
. This function was introduced in version 0.15 of libjson-c, whereas this library version is not available in Ubuntu's package sources yes. Calling this not existing function resulted in https://github.com/simsong/bulk_extractor/runs/2910172008?check_suite_focus=true#step:5:579, which should be fixed now.Best regards
Jan