search

simsong / bulk_extractor

This is the development tree. Production downloads are at:
https://github.com/simsong/bulk_extractor/releases
Other
1.11k stars 187 forks source link

Potentially erroneous exit statements in etc/CONFIGURE_UBUNTULTS18.bash #176

Closed DataFrogman closed 3 years ago

DataFrogman commented 3 years ago

File: https://github.com/simsong/bulk_extractor/blob/master/etc/CONFIGURE_UBUNTU18LTS.bash

The exit statement found on line 63 is unnecessary due to the failure check that immediately follows, furthermore it causes the script to exit with a code 1 whether or not the apt install succeeds. The exit found on line 68 also terminates the script before the script can complete. If these are not intended I can create a pull request to remove them.

simsong commented 3 years ago

Okay. Please submit a patch. Although we may just be taking this out.

DataFrogman commented 3 years ago

Addressed in https://github.com/simsong/bulk_extractor/pull/177

DataFrogman commented 3 years ago

During the update to 2.0 it appears that the bugs fixed in commits https://github.com/simsong/bulk_extractor/pull/177 and https://github.com/simsong/bulk_extractor/pull/175 were reintroduced.

simsong commented 3 years ago

They weren't re-introduced; the 2.0 fork happened before #177 and #175 were fixed! I'll apply them sometime today. Thanks.