search

simsong / bulk_extractor

This is the development tree. Production downloads are at:
https://github.com/simsong/bulk_extractor/releases
Other
1.07k stars 185 forks source link

Include bootstrap.sh instructions #352

Closed edsu closed 2 years ago

edsu commented 2 years ago

I think it would be useful to mention in the README.md that you need to run bootstrap.sh to generate the configure command. I don't believe it's mentioned in the INSTALL, but people will probably see the README on GitHub first anyway.

simsong commented 2 years ago

You don’t need to do this if you run from the .tar.gz distribution. This is only necessary if run from a git clone. Can you make this clear?

edsu commented 2 years ago

I assumed this would be the response. Good luck!

simsong commented 2 years ago

I assumed this would be the response. Good luck!

Why did you close the request? It's reasonable. People who are used to open source development with autoconf understand the situation, but others don't. I just don't want to tell everybody to run the program. So I would like to make the instructions more clear. Do you think that's a bad idea?

edsu commented 2 years ago

I closed it because I have no intention of making the changes you suggested.

simsong commented 2 years ago

But somebody else might.

simsong commented 2 years ago

Do you have no intention because you think that it's a bad request, and you disagree that it is needed?

edsu commented 2 years ago

I don't think it's a bad request. It's just beyond my abilities to act on without spending more time on it, which I don't really have unfortunately. I thought a small incremental change would be helpful.

I did start with bulk_extractor-2.0.0.tar.gz which also did not seem to include a configure. If instructions for working with the Git repo are added it would be good to indicate that a git clone --recurse-submodules is needed. Otherwise bootstrap.sh will fail. Perhaps it is by design but the bulk_extractor-2.0.0.tar.gz seems to lack dfxml_schema and src/be20_api. This also causes bootstrap.sh to fail.

simsong commented 2 years ago

Huh. That's odd. From where did you download bulk_extractor-2.0.0.tar.gz? The files available at https://github.com/simsong/bulk_extractor/releases/tag/v2.0.0 are GitHub "releases" which are just not useful for projects that include submodules, for the reasons that you note. But I could add the file bulk_extractor-2.0.0.tar.gz there if you think it would be useful.

I also think that it's getting time to delete all of the old releases. What do you think?

edsu commented 2 years ago

I downloaded the release from GitHub, which is how projects tend to use GitHub in my experience. Having the old release versions is useful. For example today I used it because I was comparing output between two versions. I'm just a dabbler in bulk_extractor land, so I don't think my opinions count for much.

simsong commented 2 years ago

Do you think that it's useful having these old releases at digitalcorpora? https://downloads.digitalcorpora.org/downloads/bulk_extractor/ image