search

simsong / bulk_extractor

This is the development tree. Production downloads are at:
https://github.com/simsong/bulk_extractor/releases
Other
1.07k stars 185 forks source link

Remove PHASE_ENABLED #358

Closed jonstewart closed 1 year ago

jonstewart commented 2 years ago

scanner_params.h defines PHASE_ENABLED, inbetween PHASE_INIT2 and PHASE_SCAN, but scanners do not seem to be called with this phase. It really only seems to be used in scanner_set.cpp in the be20_api submodule.

What is PHASE_ENABLED for?

simsong commented 2 years ago

Apparently it is now being set but never used. It was previously used to let the scanners know that initialization was over, and all of the scanners would get a message that they were now enabled, and some did additional initialization.

Now all of the scanners get called with PHASE_INIT2. After that, we are no longer in PHASE_INIT2, so it moves to PHASE_ENABLED.

I think that it can be removed.

simsong commented 1 year ago

"If it aint broke, don't fix it." It seems to be working, so let's just leave it.