search

simsong / bulk_extractor

This is the development tree. Production downloads are at:
https://github.com/simsong/bulk_extractor/releases
Other
1.04k stars 183 forks source link

Disable scanners before enabling #431

Closed dfjxs closed 7 months ago

dfjxs commented 7 months ago

Fixes #430

Disable scanners provided in arguments before enabling other scanners. This solves a bug where using -x all results in no scanners being active regardless of -e arguments provided.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (53a01ad) 47.94% compared to head (0e96bd5) 48.03%. Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #431 +/- ## ========================================== + Coverage 47.94% 48.03% +0.09% ========================================== Files 112 112 Lines 13224 13240 +16 ========================================== + Hits 6340 6359 +19 + Misses 6884 6881 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

simsong commented 7 months ago

Thanks. This is great. But we should add a test that tests this behavior and that the previous version fails on. Do you want to do that, or should I?

On Thu, Nov 23, 2023 at 11:10 PM Jason @.***> wrote:

Fixes #430 https://github.com/simsong/bulk_extractor/issues/430

Disable scanners provided in arguments before enabling other scanners. This solves a bug where using -x all results in no scanners being active regardless of -e arguments provided.

You can view, comment on, or merge this pull request online at:

https://github.com/simsong/bulk_extractor/pull/431 Commit Summary

File Changes

(1 file https://github.com/simsong/bulk_extractor/pull/431/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/simsong/bulk_extractor/pull/431, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMFHLCBHJBDLEXWJSNQVQDYF7JU3AVCNFSM6AAAAAA7YLDI6CVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYDQOBYGAZDEOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

dfjxs commented 7 months ago

Ah, good point. I'll add one.

simsong commented 7 months ago

Thanks!