search

simsong / bulk_extractor

This is the development tree. Production downloads are at:
https://github.com/simsong/bulk_extractor/releases
Other
1.04k stars 183 forks source link

Fixed wrong test_be generation in bin directory #434

Closed D3vil0p3r closed 6 months ago

simsong commented 6 months ago

Thanks! If this works, I'll bump the version number! Do you want to be added to the contributors list?

D3vil0p3r commented 6 months ago

Sure. Thanks.

I tested in NixOS and it works well with this change.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9365df0) 48.03% compared to head (6bfa183) 48.03%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #434 +/- ## ======================================= Coverage 48.03% 48.03% ======================================= Files 112 112 Lines 13240 13240 ======================================= Hits 6359 6359 Misses 6881 6881 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

D3vil0p3r commented 6 months ago

Hello @simsong Did you get the chance to review this PR?

simsong commented 6 months ago

It's good, but it also needs to update the version number. I'm going to do that when I go back to work. later today or tomorrow. Thank you again for your contribution.

simsong commented 6 months ago

PR is accepted. Updating the version number now.

D3vil0p3r commented 6 months ago

PR is accepted. Updating the version number now.

Thank you. Once updated, I will update the package in Nix repository.

simsong commented 6 months ago

What do you mean by updated? Do you need me to make a new installer? If so, where do you want it?

D3vil0p3r commented 6 months ago

What do you mean by updated? Do you need me to make a new installer? If so, where do you want it?

I mean bumping the version number because I see it is still at 2.0.3 on GitHub Release image

simsong commented 6 months ago

Done.

On Jan 2, 2024, at 6:11 PM, D3vil0p3r @.***> wrote:

What do you mean by updated? Do you need me to make a new installer? If so, where do you want it?

I mean bumping the version number because I see it is still at 2.0.3 on GitHub Release image.png (view on web) https://github.com/simsong/bulk_extractor/assets/83867734/dcaee09f-b651-4026-9fc3-f1159046261c — Reply to this email directly, view it on GitHub https://github.com/simsong/bulk_extractor/pull/434#issuecomment-1874672266, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMFHLCHAIUBPFGJUTTPO5TYMSH3ZAVCNFSM6AAAAABBILAOPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZUGY3TEMRWGY. You are receiving this because you modified the open/close state.