search

simsong / bulk_extractor

This is the development tree. Production downloads are at:
https://github.com/simsong/bulk_extractor/releases
Other
1.09k stars 187 forks source link

Rel 2.1.0 #450

Closed simsong closed 8 months ago

simsong commented 8 months ago

@jonstewart — This is how I finally addressed the Makefile complexity problem: https://github.com/simsong/bulk_extractor/blob/de3f60d7771442d3577210304f0717b6eafe6d8f/etc/makefile_builder.py#L1-L77

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a20dfe5) 48.18% compared to head (77c5224) 48.18%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #450 +/- ## ========================================== + Coverage 48.18% 48.18% +0.01% ========================================== Files 112 112 Lines 13249 13249 ========================================== + Hits 6383 6384 +1 + Misses 6866 6865 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jonstewart commented 8 months ago

a 75 line readable python script that generates a makefile is too simple and effective of a solution to ever gain traction in the software industry, but I love it all the same

simsong commented 8 months ago

It doesn't generate the makefiles. It generates an include file that is used by autoconf and automake to make the configure script that runs to make the makefiles. This way I still get all of the magic of automake including cross-compilation, compilation from read-only file systems into _build directories, make dist and make distcheck.

Note that the configuration is bundled into the script; I could put it as a separate .json file, winning the hearts and minds of the JavaScript community.

It took me a while to hit upon this idea.