Adding pcre support - Githubissues

simsong / bulk_extractor

This is the development tree. Production downloads are at:

https://github.com/simsong/bulk_extractor/releases

Other

1.04k stars 183 forks source link

Adding pcre support #467

Closed D3vil0p3r closed 2 months ago

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.18%. Comparing base (6a7da28) to head (069bf98).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #467 +/- ## ======================================= Coverage 48.18% 48.18% ======================================= Files 112 112 Lines 13249 13249 ======================================= Hits 6383 6383 Misses 6866 6866 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

simsong commented 2 months ago

Why did you close this PR?

simsong commented 2 months ago

pcre is added for platforms that do not have RE2 libraries available. RE2 is much, much better, but it is difficult to build.

simsong commented 2 months ago

Oh, this PR doesn't add the flag, it just checked for the .h file...

D3vil0p3r commented 2 months ago

@simsong because I noted that by installing pcre dependency, I don't get the issue. Probably this PR was not needed.

simsong commented 2 months ago

it should detect if pcre is not installed and not create a problem.

On Sat, Apr 20, 2024 at 5:10 PM D3vil0p3r @.***> wrote:

@simsong https://github.com/simsong because I noted that by installing pcre dependency, I don't get the issue. Probably this PR was not needed.

— Reply to this email directly, view it on GitHub https://github.com/simsong/bulk_extractor/pull/467#issuecomment-2067781782, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMFHLH7PFSJEILLWYFI2NDY6LKSDAVCNFSM6AAAAABGQXMROKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRXG44DCNZYGI . You are receiving this because you were mentioned.Message ID: @.***>